Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ruff.toml causing types directory to be ignore and fix subsequent lint errors #8218

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Feb 4, 2024

The ruff.toml file in ibis/expr/types was causing the module to be ignored by ruff. This PR removes that file since it is no longer necessary, and fixes the resulting lint and format issues. I also added a new ignore rule to prevent an additional newline from being added to the end docstrings (D413).

@cpcloud cpcloud added this to the 8.0 milestone Feb 4, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis developer-tools Tools related to ibis development labels Feb 4, 2024
@cpcloud cpcloud requested a review from kszucs February 4, 2024 13:09
@kszucs kszucs enabled auto-merge (rebase) February 4, 2024 13:18
@kszucs kszucs merged commit 4f62118 into ibis-project:main Feb 4, 2024
85 checks passed
@cpcloud cpcloud deleted the uncover-linting-issues branch February 4, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis developer-tools Tools related to ibis development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants