fix(common): don't match an Object pattern with more positional arguments defined than __match_args__ has
#8124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
force-pushed
the
object-pattern-validation
branch
2 times, most recently
from
440bc4c to
5f73380
Compare
kszucs
changed the title
Object pattern with more positional arguments defined than value.__match_args__ hasObject pattern with more positional arguments defined than __match_args__ has
kszucs
commented
Jan 28, 2024
kszucs
force-pushed
the
object-pattern-validation
branch
from
5f73380 to
bb9b235
Compare
cpcloud
requested changes
Jan 29, 2024
kszucs
force-pushed
the
object-pattern-validation
branch
from
bb9b235 to
1070f0c
Compare
|
@cpcloud addressed your comments |
kszucs
force-pushed
the
object-pattern-validation
branch
from
1070f0c to
81470b1
Compare
|
I'm not sure why that job is failing, I thought we moved away from those caching actions. |
|
Oh, that's not yet in |
…uments defined than `__match_args__` has
cpcloud
force-pushed
the
object-pattern-validation
branch
from
81470b1 to
ec974cf
Compare
cpcloud
added
bug
cpcloud
approved these changes
Feb 1, 2024
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out one of the patterns were referencing non-existing fields and the
Objectpattern was still matching on it.Fixes #8058.