feat(mssql): add hashbytes and test for binary output hash fns #8107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
force-pushed
the
hashbytes
branch
2 times, most recently
from
86e29d2 to
4efcdbf
Compare
jcrist
reviewed
Jan 26, 2024
|
Should we discuss deprecating whichever other method overlaps with the new |
cpcloud
reviewed
Jan 26, 2024
feat(mssql): add hexdigest Apply suggestions from code review Co-authored-by: Jim Crist-Harif <[email protected]>
So it would be hashbytes, although currently there is a difference in that hashbytes returns the binary hash and there are at least a few backends that support both of those options. |
cpcloud
approved these changes
Jan 29, 2024
gforsyth
added a commit
to gforsyth/ibis
that referenced
this pull request
Feb 1, 2024
…project#8107) This adds support for `ops.HashBytes` to `mssql` and also adds a test for that functionality so it's easier to port when we merge in the epic split branch. I've also added a new op, `HashHexDigest` which returns the hexdigest of various cryptographic hashing functions since I imagine this is what many users are _probably_ after. This newer op (and corresponding `hexdigest` method) can also support many more backends, as most of them default to returning the string hex digest and not the raw binary output. I tried to be very accurate in the `notimpl` and `notyet` portions of both tests and I think I've done that. For now, only exposing DuckDB, Pyspark, and MSSQL so we don't add a huge extra burden for the epic split but also address the user request in And I guess now we can commence debate over the method name? 🐎 Resolves ibis-project#8082 --------- Co-authored-by: Jim Crist-Harif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds support for
ops.HashBytestomssqland also adds a test for that functionality so it's easier to port when we merge in the epic split branch.I've also added a new op,
HashHexDigestwhich returns the hexdigest of various cryptographic hashing functions since I imagine this is what many users are probably after. This newer op (and correspondinghexdigestmethod) can also support many more backends, as most of them default to returning the string hex digest and not the raw binary output.I tried to be very accurate in the
notimplandnotyetportions of both tests and I think I've done that.For now, only exposing DuckDB, Pyspark, and MSSQL so we don't add a huge extra burden for the epic split but also address the user request in #8082
And I guess now we can commence debate over the method name? 🐎
Issues closed
Resolves #8082