fix(datatypes): ensure that array construction supports literals and infers their shape from its inputs #8049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
force-pushed
the
fix-array-construction-abstraction
branch
from
5f094be to
8644eaa
Compare
NickCrews
reviewed
Jan 20, 2024
NickCrews
requested changes
Jan 20, 2024
| if isinstance(v, dd.Series): | ||
| return v | ||
| else: | ||
| return dd.from_pandas(pd.Series([v] * length), npartitions=n_partitions) |
There was a problem hiding this comment.
also worth double checking me here, I'm not familiar with dask, so I was mostly just trying to make this not crash, but I'm not sure if setting n_partitions this way makes sense/is the most performant.
BREAKING CHANGE: The `type` argument is removed from `ibis.array`. Ibis will attempt to infer the type of your input as it did before. If you need a specific type, cast the return value of `ibis.array` to a specific array type.
pd.concat and dd.concat can only handle array-likes. If we are given a scalar, we need to convert it to the appropriate Series type.
cpcloud
force-pushed
the
fix-array-construction-abstraction
branch
from
4ccbb15 to
b9f9bbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously returning
ArrayColumnfromibis.arraywhen any inputs were expressions regardless of their shape. This PR renamesArrayColumn->Arrayand uses the input arguments shapes to determine the output array shape.Fixes #8022.