refactor(exasol): port to sqlglot #8032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
refactor
21 tasks
cpcloud
commented
Jan 19, 2024
cpcloud
commented
Jan 19, 2024
| @pytest.mark.broken( | ||
| ["exasol"], | ||
| raises=ExaQueryError, | ||
| reason="database can't handle UTC timestamps in DataFrames", |
There was a problem hiding this comment.
This might be fixable if we get rid of import_from_pandas and do the inserts ourselves.
kszucs
reviewed
Jan 19, 2024
| ) | ||
| @pytest.mark.notimpl(["exasol"], raises=ExaQueryError) |
There was a problem hiding this comment.
Just a nit and unrelated to this pr is that the exception name ExaQueryError is not consistent with the rest of the error types having full backend name as the prefix, so I think it should be ExasolQueryError
kszucs
reviewed
Jan 19, 2024
| name = _NAMES.get(con.name, "functional_alltypes") | ||
| quoted = getattr(getattr(con, "compiler", None), "quoted", True) | ||
| dialect = _IBIS_TO_SQLGLOT_DIALECT.get(con.name, con.name) | ||
| cols = [ |
There was a problem hiding this comment.
Required due to backend specific quoting?
There was a problem hiding this comment.
Yes. This effectively makes identifiers case sensitive
kszucs
reviewed
Jan 19, 2024
| @@ -214,7 +213,9 @@ def test_table_to_parquet(tmp_path, backend, awards_players): | |||
|
|
|||
| df = pd.read_parquet(outparquet) | |||
|
|
|||
| backend.assert_frame_equal(awards_players.to_pandas(), df) | |||
| backend.assert_frame_equal( | |||
| awards_players.to_pandas().fillna(pd.NA), df.fillna(pd.NA) | |||
There was a problem hiding this comment.
Phase 2 after the port?? 😂
There was a problem hiding this comment.
Probably, we should clean up the output coercions.
kszucs
pushed a commit
to kszucs/ibis
that referenced
this pull request
Feb 1, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
kszucs
pushed a commit
to kszucs/ibis
that referenced
this pull request
Feb 1, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
kszucs
pushed a commit
to kszucs/ibis
that referenced
this pull request
Feb 1, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
kszucs
pushed a commit
to kszucs/ibis
that referenced
this pull request
Feb 2, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
kszucs
pushed a commit
to kszucs/ibis
that referenced
this pull request
Feb 2, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
kszucs
pushed a commit
to kszucs/ibis
that referenced
this pull request
Feb 2, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Feb 4, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Feb 5, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
kszucs
pushed a commit
that referenced
this pull request
Feb 5, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
kszucs
pushed a commit
that referenced
this pull request
Feb 6, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
kszucs
pushed a commit
that referenced
this pull request
Feb 6, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Feb 12, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
cpcloud
added a commit
that referenced
this pull request
Feb 12, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Feb 12, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
cpcloud
added a commit
that referenced
this pull request
Feb 12, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
kszucs
pushed a commit
that referenced
this pull request
Feb 12, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
ncclementi
pushed a commit
to ncclementi/ibis
that referenced
this pull request
Feb 21, 2024
This PR ports exasol to sqlglot instead of sqlalchemy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports exasol to sqlglot instead of sqlalchemy.