refactor(oracle): port to sqlglot

.github/workflows/ibis-backends.yml

@@ -155,20 +155,20 @@ jobs:
               - druid
             services:
               - druid
-          # - name: oracle
-          #   title: Oracle
-          #   serial: true
-          #   extras:
-          #     - oracle
-          #   services:
-          #     - oracle
           - name: exasol
             title: Exasol
             serial: true
             extras:
               - exasol
             services:
               - exasol
+          - name: oracle
+            title: Oracle
+            serial: true
+            extras:
+              - oracle
+            services:
+              - oracle
           # - name: flink
           #   title: Flink
           #   serial: true
@@ -265,15 +265,15 @@ jobs:
                 - druid
               services:
                 - druid
-          # - os: windows-latest
-          #   backend:
-          #     name: oracle
-          #     title: Oracle
-          #     serial: true
-          #     extras:
-          #       - oracle
-          #     services:
-          #       - oracle
+          - os: windows-latest
+            backend:
+              name: oracle
+              title: Oracle
+              serial: true
+              extras:
+                - oracle
+              services:
+                - oracle
           # - os: windows-latest
           #   backend:
           #     name: flink

ibis/backends/base/sqlglot/datatypes.py

@@ -563,6 +563,29 @@
 class OracleType(SqlglotType):
     dialect = "oracle"
 
+    default_decimal_precision = 38
+    default_decimal_scale = 9
+
+    default_temporal_scale = 9
+
+    unknown_type_strings = FrozenDict({"raw": dt.binary})
+
+    @classmethod
+    def _from_sqlglot_FLOAT(cls) -> dt.Float64:
+        return dt.Float64(nullable=cls.default_nullable)
+
+    @classmethod
+    def _from_sqlglot_DECIMAL(cls, precision=None, scale=None) -> dt.Decimal:
+        if scale is None or int(scale.this.this) == 0:
+            return dt.Int64(nullable=cls.default_nullable)
+        else:
+            return super()._from_sqlglot_DECIMAL(precision, scale)
+
+    @classmethod
+    def _from_ibis_String(cls, dtype: dt.String) -> sge.DataType:
+        nullable = " NOT NULL" if not dtype.nullable else ""
+        return "VARCHAR2(4000)" + nullable
+
 
 class SnowflakeType(SqlglotType):
     dialect = "snowflake"

ibis/backends/conftest.py

@@ -22,6 +22,7 @@
 from ibis import util
 from ibis.backends.base import CanCreateDatabase, CanCreateSchema, _get_backend_names
 from ibis.conftest import WINDOWS
+from ibis.util import promote_tuple
 
 if TYPE_CHECKING:
     from collections.abc import Iterable
@@ -418,6 +419,13 @@ def pytest_runtest_call(item):
         # TODO: there has to be a better way than hacking `_fixtureinfo`
         item._fixtureinfo.argnames += ("backend", "snapshot")
 
+    def _filter_none_from_raises(kwargs):
+        # Filter out any None values from kwargs['raises']
+        # to cover any missing backend error types as defined in ibis/backends/tests/errors.py
+        if (raises := kwargs.get("raises")) is not None:
+            kwargs["raises"] = tuple(filter(None, promote_tuple(raises)))
+        return kwargs
+
     # Ibis hasn't exposed existing functionality
     # This xfails so that you know when it starts to pass
     for marker in item.iter_markers(name="notimpl"):
@@ -429,6 +437,7 @@ def pytest_runtest_call(item):
                 raise ValueError("notimpl requires a raises")
             kwargs = marker.kwargs.copy()
             kwargs.setdefault("reason", f"Feature not yet exposed in {backend}")
+            kwargs = _filter_none_from_raises(kwargs)
             item.add_marker(pytest.mark.xfail(**kwargs))
 
     # Functionality is unavailable upstream (but could be)
@@ -443,13 +452,16 @@ def pytest_runtest_call(item):
 
             kwargs = marker.kwargs.copy()
             kwargs.setdefault("reason", f"Feature not available upstream for {backend}")
+            kwargs = _filter_none_from_raises(kwargs)
             item.add_marker(pytest.mark.xfail(**kwargs))
 
     for marker in item.iter_markers(name="never"):
         if backend in marker.args[0]:
             if "reason" not in marker.kwargs.keys():
                 raise ValueError("never requires a reason")
-            item.add_marker(pytest.mark.xfail(**marker.kwargs))
+            kwargs = marker.kwargs.copy()
+            kwargs = _filter_none_from_raises(kwargs)
+            item.add_marker(pytest.mark.xfail(**kwargs))
 
     # Something has been exposed as broken by a new test and it shouldn't be
     # imperative for a contributor to fix it just because they happened to
@@ -464,10 +476,12 @@ def pytest_runtest_call(item):
 
             kwargs = marker.kwargs.copy()
             kwargs.setdefault("reason", f"Feature is failing on {backend}")
+            kwargs = _filter_none_from_raises(kwargs)
             item.add_marker(pytest.mark.xfail(**kwargs))
 
     for marker in item.iter_markers(name="xfail_version"):
         kwargs = marker.kwargs.copy()
+        kwargs = _filter_none_from_raises(kwargs)
         if backend not in kwargs:
             continue
 
@@ -549,10 +563,7 @@ def ddl_con(ddl_backend):
     return ddl_backend.connection
 
 
-@pytest.fixture(
-    params=_get_backends_to_test(keep=("mssql", "oracle", "sqlite")),
-    scope="session",
-)
+@pytest.fixture(params=_get_backends_to_test(keep=("mssql", "sqlite")), scope="session")
 def alchemy_backend(request, data_dir, tmp_path_factory, worker_id):
     """Set up the SQLAlchemy-based backends."""
     return _setup_backend(request, data_dir, tmp_path_factory, worker_id)