Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ibis-analytics blog post #7990

Merged
merged 10 commits into from
Jan 25, 2024
Merged

docs: ibis-analytics blog post #7990

merged 10 commits into from
Jan 25, 2024

Conversation

lostmygithubaccount
Copy link
Member

@lostmygithubaccount lostmygithubaccount commented Jan 16, 2024

Description of changes

note the blog was already in the repo in draft mode. since it was written, the code was updated a bit. this finishes the blog and removes draft mode

Issues closed

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jan 16, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jan 16, 2024
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jan 16, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jan 16, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jan 16, 2024

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jan 16, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jan 16, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jan 16, 2024

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

Ibis plays a part but is only one component in any real data project. We'll look at how to combine a variety of open-source tools and freemium services including:
As a Python data user, I've wanted a more modular, composable, and scalable
ecosystem. *I think it's here*. Wes McKinney released pandas c. 2009 to bring
dataframes into Python and it became one of the most used software packages. It
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dataframes into Python and it became one of the most used software packages. It
the power of SQL to Python via the DataFrame and it became one of the most used software packages. It

I think this may appeal to a slightly more general audience.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is on pandas? it didn't use/bring the power of SQL?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Literally no, but it brought the concepts (and the conceptual power) of SQL to the forefront of the Python ecosystem.

docs/posts/ibis-analytics/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-analytics/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-analytics/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-analytics/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-analytics/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-analytics/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-analytics/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-analytics/index.qmd Show resolved Hide resolved
docs/posts/ibis-analytics/index.qmd Outdated Show resolved Hide resolved
@cpcloud cpcloud added this to the 8.0 milestone Jan 16, 2024
@cpcloud cpcloud added the docs Documentation related issues or PRs label Jan 16, 2024
@lostmygithubaccount lostmygithubaccount marked this pull request as ready for review January 16, 2024 13:17
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jan 16, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jan 16, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jan 16, 2024

Copy link
Contributor

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content!

My only worry is that the blog seems super long because all of the code and some other renders like data /ingest, dag/assets, data/system, etc are shown. I wonder if we need all of the code and data directory/architecture shown.

It might be worth highlighting some parts of the scripts that you want to show, and then just link to the code in case someone wants to see it fully. Otherwise I find myself scrolling through code and after couple of scrolls I kind of want to stop reading.

Comment on lines 18 to 21
was built when small data was smaller and though still an excellent dataframe
library today has some downsides [Wes wrote about in his "Apache Arrow and the
'10 things I hate about pandas'" blog
post](https://wesmckinney.com/blog/apache-arrow-pandas-internals). Wes created
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is a bit too long, and I'm losing the train of thought. Not sure what's the bet way, but maybe something like:
"I was built when small data was smaller and though still an excellent dataframe
library today. But it has some downsides, Wes wrote about in his "Apache Arrow and the
'10 things I hate about pandas'" blog
post
."

@lostmygithubaccount
Copy link
Member Author

@ncclementi I wanted to wrap most of the longer code. I didn't want to link to it because that's likely to break in the future. in Quarto, you can't wrap non-executed code for reasons

there is a workaround noted here: quarto-dev/quarto-cli#4693 (comment) I'll add that for some of the larger bits

@ncclementi
Copy link
Contributor

there is a workaround noted here: quarto-dev/quarto-cli#4693 (comment) I'll add that for some of the larger bits

Nice, I didn't know that worked on quarto too. It works on Github markdown.

Display me

I like that idea!!

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jan 16, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jan 16, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jan 16, 2024

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jan 16, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jan 16, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jan 16, 2024

@lostmygithubaccount
Copy link
Member Author

let's hold off on merging to perhaps Friday or so given another blog was merged today

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jan 24, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jan 24, 2024
@lostmygithubaccount
Copy link
Member Author

I think this is good to merge today or tomorrow, set the date to tomorrow

@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jan 24, 2024

@cpcloud cpcloud merged commit 17a1ef2 into ibis-project:main Jan 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants