Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flink): implement array operators #7951

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

mfatihaktas
Copy link
Contributor

@mfatihaktas mfatihaktas commented Jan 10, 2024

Description of changes

Adds several new array operators for Flink backend. The goal with this is to clear as many of the tests in ibis/ibis/backends/tests/test_array.py as possible for the Flink backend.

@mfatihaktas mfatihaktas force-pushed the feat/array-types branch 6 times, most recently from 1484ca5 to 74ebd05 Compare January 10, 2024 22:38
ibis/backends/flink/registry.py Outdated Show resolved Hide resolved
ibis/backends/tests/test_array.py Outdated Show resolved Hide resolved
ibis/backends/tests/test_array.py Outdated Show resolved Hide resolved
ibis/backends/tests/test_array.py Outdated Show resolved Hide resolved
ibis/backends/tests/test_array.py Outdated Show resolved Hide resolved
ibis/backends/tests/test_array.py Outdated Show resolved Hide resolved
ibis/backends/tests/test_array.py Outdated Show resolved Hide resolved
@mfatihaktas mfatihaktas force-pushed the feat/array-types branch 2 times, most recently from c07052c to 1e22248 Compare January 11, 2024 22:05
@mfatihaktas mfatihaktas requested a review from cpcloud January 11, 2024 22:40
@mfatihaktas mfatihaktas marked this pull request as ready for review January 11, 2024 22:40
@cpcloud cpcloud added the flink Issues or PRs related to Flink label Jan 16, 2024
@mfatihaktas mfatihaktas force-pushed the feat/array-types branch 8 times, most recently from 266e8fb to c75ea04 Compare January 22, 2024 19:07
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of stylistic nits, but otherwise looks good!

ibis/backends/flink/registry.py Outdated Show resolved Hide resolved
ibis/backends/flink/registry.py Outdated Show resolved Hide resolved
ibis/backends/flink/registry.py Outdated Show resolved Hide resolved
ibis/backends/tests/test_map.py Show resolved Hide resolved
Copy link
Contributor

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments

ibis/backends/flink/registry.py Outdated Show resolved Hide resolved
ibis/backends/flink/registry.py Outdated Show resolved Hide resolved
ibis/backends/flink/registry.py Outdated Show resolved Hide resolved
@cpcloud
Copy link
Member

cpcloud commented Jan 31, 2024

@mfatihaktas Can you rebase? I thought we had merged this, apologies for the delay!

@cpcloud cpcloud added this to the 8.0 milestone Jan 31, 2024
@cpcloud cpcloud added the feature Features or general enhancements label Jan 31, 2024
@cpcloud cpcloud enabled auto-merge (squash) January 31, 2024 17:07
auto-merge was automatically disabled January 31, 2024 17:13

Head branch was pushed to by a user without write access

@cpcloud cpcloud enabled auto-merge (squash) January 31, 2024 17:24
@cpcloud cpcloud merged commit 80e13b4 into ibis-project:main Jan 31, 2024
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements flink Issues or PRs related to Flink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants