Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(flink): deep dive on the tests marked for Flink in test_json.py #7908

Merged

Conversation

mfatihaktas
Copy link
Contributor

Reviving #7777 which got closed after switching to main.

@cpcloud cpcloud added the flink Issues or PRs related to Flink label Jan 16, 2024
@mfatihaktas mfatihaktas force-pushed the flink-deep-dive-on-test_json-2 branch 4 times, most recently from 1ca0eb0 to 1141e89 Compare January 17, 2024 16:23
@mfatihaktas mfatihaktas requested a review from jcrist January 17, 2024 19:26
@mfatihaktas mfatihaktas force-pushed the flink-deep-dive-on-test_json-2 branch 2 times, most recently from 0a47b51 to 4d28474 Compare January 19, 2024 20:14
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small nits, but provided tests pass this LGTM.

ibis/backends/flink/__init__.py Outdated Show resolved Hide resolved
ibis/backends/flink/__init__.py Outdated Show resolved Hide resolved
@mfatihaktas mfatihaktas force-pushed the flink-deep-dive-on-test_json-2 branch from 4d28474 to 910c542 Compare January 19, 2024 20:24
@mfatihaktas mfatihaktas requested a review from jcrist January 19, 2024 20:27
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided tests pass this LGTM

@mfatihaktas mfatihaktas force-pushed the flink-deep-dive-on-test_json-2 branch from 910c542 to d146b46 Compare January 19, 2024 21:36
@cpcloud cpcloud added this to the 8.0 milestone Jan 21, 2024
@cpcloud cpcloud merged commit 3eebc41 into ibis-project:main Jan 21, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flink Issues or PRs related to Flink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants