-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(flink): deep dive on the tests marked for Flink in test_json.py #7908
Merged
cpcloud
merged 1 commit into
ibis-project:main
from
mfatihaktas:flink-deep-dive-on-test_json-2
Jan 21, 2024
Merged
test(flink): deep dive on the tests marked for Flink in test_json.py #7908
cpcloud
merged 1 commit into
ibis-project:main
from
mfatihaktas:flink-deep-dive-on-test_json-2
Jan 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfatihaktas
commented
Jan 9, 2024
mfatihaktas
force-pushed
the
flink-deep-dive-on-test_json-2
branch
4 times, most recently
from
January 17, 2024 16:23
1ca0eb0
to
1141e89
Compare
jcrist
reviewed
Jan 18, 2024
mfatihaktas
force-pushed
the
flink-deep-dive-on-test_json-2
branch
2 times, most recently
from
January 19, 2024 20:14
0a47b51
to
4d28474
Compare
jcrist
reviewed
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small nits, but provided tests pass this LGTM.
mfatihaktas
force-pushed
the
flink-deep-dive-on-test_json-2
branch
from
January 19, 2024 20:24
4d28474
to
910c542
Compare
jcrist
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided tests pass this LGTM
mfatihaktas
force-pushed
the
flink-deep-dive-on-test_json-2
branch
from
January 19, 2024 21:36
910c542
to
d146b46
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviving #7777 which got closed after switching to
main
.