Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(udf): support inputs without type annotations #7122

Merged
merged 2 commits into from
Sep 12, 2023
Merged

feat(udf): support inputs without type annotations #7122

merged 2 commits into from
Sep 12, 2023

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 11, 2023 •
edited
Loading

Adds support for eliding inputs types to UDFs.

Depends on #7119.

@cpcloud cpcloud added this to the 7.0 milestone Sep 11, 2023
@cpcloud cpcloud added feature Features or general enhancements ux User experience related issues labels Sep 11, 2023
@cpcloud cpcloud requested a review from jcrist September 11, 2023 18:34
@cpcloud cpcloud changed the title builtin udf no types feat(udf): support inputs without type annotations Sep 11, 2023
@cpcloud cpcloud added the udf Issues related to user-defined functions label Sep 11, 2023
kszucs
kszucs reviewed Sep 11, 2023
View reviewed changes
ibis/expr/operations/udf.py Outdated Show resolved Hide resolved
@cpcloud cpcloud mentioned this pull request Sep 12, 2023
Merged
kszucs
kszucs approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rebasing and pushing the missing change it is good to go.

@cpcloud cpcloud force-pushed the builtin-udf-no-types branch from 746dc13 to 9005045 Compare September 12, 2023 17:08
@cpcloud cpcloud enabled auto-merge (rebase) September 12, 2023 17:15
@cpcloud cpcloud merged commit 78714d0 into ibis-project:master Sep 12, 2023
@cpcloud cpcloud deleted the builtin-udf-no-types branch September 12, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszucs kszucs kszucs approved these changes

@jcrist jcrist Awaiting requested review from jcrist

Assignees
No one assigned
Labels
feature Features or general enhancements udf Issues related to user-defined functions ux User experience related issues
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @kszucs