-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dev): replace current flake8-based and other linting tools with ruff
#5057
Conversation
8e657e4
to
14128df
Compare
Codecov Report
@@ Coverage Diff @@
## master #5057 +/- ##
==========================================
- Coverage 95.06% 91.29% -3.77%
==========================================
Files 394 388 -6
Lines 44018 43416 -602
Branches 4319 4293 -26
==========================================
- Hits 41846 39638 -2208
- Misses 1668 3290 +1622
+ Partials 504 488 -16
|
@cpcloud can you add a more descriptive name to the PR? :) |
ruff
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After including the breaking change note it looks good to me!
I'll squash into a single commit. |
Replace flake8 and friends with `ruff`. BREAKING CHANGE: Expression types have been removed from `ibis.expr.api`. Use `import ibis.expr.types as ir` to access these types.
I have
|
This PR replaces all of our flake8 checks and tools with
ruff
, which is Python linter implemented in Rust designed to be fast, lightweight and combine the most commonly used flake8 plugins into a single tool. While I do not care too much about the performance for ibis developement (though I do for my LSP configuration!) I do care about tool consolidation, which is the main purpose of this PR.