test(sqlite): fix test flakiness caused by failing to close sqlite3.Connection objects
#10597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
|
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
cpcloud
changed the title
sqlite3.Connection objects
cpcloud
force-pushed
the
fix-sqlite-test-flakiness
branch
from
a0531bf to
d8f3702
Compare
cpcloud
force-pushed
the
fix-sqlite-test-flakiness
branch
from
d8f3702 to
0bb107d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued to observe this, so I took a closer look and it turns out that the context manager does not close the connection, it only handles transaction behavior. This PR fixes the resource warnings that show up only in Python 3.13