Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): enable running uv lock command in devcontainer #10576

Merged
merged 2 commits into from
Dec 14, 2024
Merged

fix(deps): enable running uv lock command in devcontainer #10576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
958aa76
Activate default virtual environment named venv
nickpowersys Dec 13, 2024
1cae9bd
Update docs to ensure fork is synced before updated devcontainer build
nickpowersys Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ COPY . /app
RUN --mount=type=cache,target=/root/.cache/uv \
--mount=type=bind,source=uv.lock,target=uv.lock \
--mount=type=bind,source=pyproject.toml,target=pyproject.toml \
uv sync --group dev --group tests \
uv venv && uv sync --group dev --group tests \
--extra duckdb --extra clickhouse --extra examples --extra geospatial

ENV VENV_DIR=.venv
Expand All @@ -36,6 +36,8 @@ RUN chown -R $USERNAME $IBIS_PROJECT
# Place executables in the environment at the front of the path
ENV PATH="/app/.venv/bin:$PATH"

SHELL ["/bin/bash", "-c", "source .venv/bin/activate"]

ENTRYPOINT []

USER $USERNAME
3 changes: 2 additions & 1 deletion docs/contribute/01_environment.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,10 +238,11 @@ for manager, params in managers.items():
1. To exit a container, click the `Dev Container` button on the lower left of the
window and select the last menu option, `Close Remote Connection`.

1. To ensure you have the latest dependencies from the main branch based on
1. To ensure you have the latest dependencies from the main upstream branch based on
`pyproject.toml`:

* Exit any running container.
* Sync your fork.
* From your local Git repo, `git pull origin main`.
* Reopen the project in a new container.
* `Rebuild Container` to copy files from the local Git repo and have the build
Expand Down
Loading