Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datatypes): ensure that decimals can be upcast when source precision, scale are lte to their target fields #10470

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix(datatypes): ensure that decimals can be upcast when source precision, scale are lte to their target fields #10470

merged 1 commit into from
Nov 11, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Nov 11, 2024

Looks like we had some flipped logic in the castable branch for decimals that did not allow upcasting. Fixes #10467.

@cpcloud cpcloud added this to the 10.0 milestone Nov 11, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) labels Nov 11, 2024
@github-actions github-actions bot added the tests Issues or PRs related to tests label Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud cpcloud force-pushed the fix-schema-when-describing branch from 02dbe13 to ea7101b Compare November 11, 2024 15:41
@cpcloud cpcloud requested a review from gforsyth November 11, 2024 15:41
@cpcloud cpcloud changed the title fix(datatypes): ensure that decimals can be upcast when both source precision and source scale are less than or equal to their respective target fields fix(datatypes): ensure that decimals can be upcast when source precision, scale are lte to their target fields Nov 11, 2024
@cpcloud cpcloud force-pushed the fix-schema-when-describing branch from ea7101b to 95dc652 Compare November 11, 2024 15:45
@cpcloud cpcloud force-pushed the fix-schema-when-describing branch from 95dc652 to e4d5087 Compare November 11, 2024 15:59
gforsyth
gforsyth approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gforsyth gforsyth merged commit 5ce906a into ibis-project:main Nov 11, 2024
76 checks passed
@cpcloud cpcloud deleted the fix-schema-when-describing branch November 13, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) tests Issues or PRs related to tests
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

Possible bug in df.describe
2 participants
@cpcloud @gforsyth