Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): add temporal truncate examples #10367

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

IndexSeek
Copy link
Member

Description of changes

Adds doc examples for the TimestampValue and DateValue truncate methods.

@IndexSeek IndexSeek force-pushed the more-temporal-examples branch from 5537a67 to 13dc9ad Compare October 24, 2024 23:35
@IndexSeek
Copy link
Member Author

Is it worthwhile to break this up into additional examples or maybe not include so many columns?

I think demonstrating the behavior here is helpful, especially for truncating down to the week, where the year can change due to the start of the week.

@cpcloud cpcloud force-pushed the more-temporal-examples branch from 13dc9ad to b396479 Compare October 26, 2024 11:51
@cpcloud cpcloud added this to the 10.0 milestone Oct 26, 2024
@cpcloud cpcloud added the docs Documentation related issues or PRs label Oct 26, 2024
@cpcloud
Copy link
Member

cpcloud commented Oct 26, 2024

Is it worthwhile to break this up into additional examples or maybe not include so many columns?

I think demonstrating the behavior here is helpful, especially for truncating down to the week, where the year can change due to the start of the week.

Fine to do this in a follow-up. Thanks for churning all these examples out!

@cpcloud cpcloud added the timestamps Issues related to the timestamp API label Oct 26, 2024
@cpcloud cpcloud force-pushed the more-temporal-examples branch from 6fef7c8 to 3aa6317 Compare October 26, 2024 11:58
@cpcloud cpcloud enabled auto-merge (squash) October 26, 2024 11:58
@cpcloud cpcloud disabled auto-merge October 26, 2024 12:06
@cpcloud cpcloud merged commit 41a9b7d into ibis-project:main Oct 26, 2024
75 checks passed
@IndexSeek IndexSeek deleted the more-temporal-examples branch October 26, 2024 12:54
@IndexSeek
Copy link
Member Author

Fine to do this in a follow-up. Thanks for churning all these examples out!

Awesome, thank you for the review and for the new commit. That gives me a good example for adding more examples here. I will keep on keeping on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs timestamps Issues related to the timestamp API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants