-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): respect order of ops in FloorDivide #10353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Uhhhh it is VERY annoying to get these very opaque flink errors and then not be able to run flink locally to debug. @cpcloud any idea what the problem here is? |
Ultimately the error isn't opaque in this case: It is possible to run the Flink backend, but it's a bit of a slog to get it working due to their Python API requiring an ancient version of arrow. |
6e380f1
to
e8f1a75
Compare
Ah, thanks, I didn't see that buried in the rest of the stacktrace. I will look harder next time. I wonder if this is pointing to that |
e8f1a75
to
5ad6031
Compare
5ad6031
to
fb85936
Compare
int division test filed at #10359 |
Consider
ibis.literal(6) // (1 / ibis.literal(2))
.Before, this compiled to
6 / 1 / 2 -> 3
, when we really want6 / (1 / 2) -> 12
.This fixes that.
Found in NickCrews/mismo#74