Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): standardize NULL handling of argmin/argmax #10227

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

jcrist
Copy link
Member

@jcrist jcrist commented Sep 25, 2024

This standardizes the NULL handling behavior of argmin/argmax to better match user expectations and the common implementation of the SQL min_by/max_by methods.

Previously some backends would jump through hoops to avoid returning NULL values from these methods, even if the value that minimized the column was NULL. We now no longer do this (and workaround the compatibility issues in a few backends that did this by default). Fixes #10193.

@github-actions github-actions bot added tests Issues or PRs related to tests polars The polars backend labels Sep 25, 2024
@cpcloud cpcloud added this to the 10.0 milestone Sep 26, 2024
@cpcloud cpcloud enabled auto-merge (squash) September 26, 2024 10:22
@cpcloud cpcloud merged commit 51335ed into ibis-project:main Sep 26, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polars The polars backend tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(api): option to include nulls in argmin/argmax
2 participants