Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(bigquery): check the correct exception for missing tables #10137

Merged
merged 1 commit into from
Sep 16, 2024
Merged

test(bigquery): check the correct exception for missing tables #10137

merged 1 commit into from
Sep 16, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 16, 2024

Small adjustment to bigquery tests after unifying table exceptions in #9695.

@cpcloud cpcloud added this to the 10.0 milestone Sep 16, 2024
@cpcloud cpcloud added tests Issues or PRs related to tests bigquery The BigQuery backend labels Sep 16, 2024
@cpcloud cpcloud requested a review from ncclementi September 16, 2024 11:15
@cpcloud
Copy link
Member Author

cpcloud commented Sep 16, 2024

Test is passing after this change:

ibis/backends/bigquery/tests/system/test_connect.py::test_client_with_regional_endpoints PASSED [100%]

========================================================================================= 1 passed in 10.04s =========================================================================================

@cpcloud cpcloud merged commit 1983675 into ibis-project:main Sep 16, 2024
77 checks passed
@cpcloud cpcloud deleted the fix-bigquery-test-failure branch September 16, 2024 11:21
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Sep 24, 2024
@cpcloud @ncclementi
test(bigquery): check the correct exception for missing tables (ibis-…
b54f528 
…project#10137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncclementi ncclementi Awaiting requested review from ncclementi

Assignees
No one assigned
Labels
bigquery The BigQuery backend tests Issues or PRs related to tests
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@cpcloud