Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dropdowns): make dropdowns scrollable and easier to see in navigation bar #10090

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

ramlakhanmadheshiya
Copy link
Contributor

Description of changes

Dropdowns and tools in navigation bar were not appearing properly, I have added some custom CSS to fix it!

Left long dropdowns Right tools dropdown
image image
After this PR After this PR
added a scroll bar image image

Copy link
Contributor

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@ramlakhanmadheshiya ramlakhanmadheshiya changed the title fixed dropdowns in navigation bar fix: dropdowns in navigation bar Sep 11, 2024
@lostmygithubaccount lostmygithubaccount added docs Documentation related issues or PRs docs-preview Add this label to trigger a docs preview labels Sep 11, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Sep 11, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Sep 11, 2024

@cpcloud
Copy link
Member

cpcloud commented Sep 11, 2024

This seems like something that should be fixed upstream in Quarto, or perhaps even one feature and one bugfix.

  • Feature: scrolling dropdowns
  • Fix: avoid rendering outside of the left or right viewport

@ramlakhanmadheshiya
Copy link
Contributor Author

We could use the part of CSS I added until Quarto fixes it! I will open an issue for this in Quarto!

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a shot! We can always revert if people complain or something gets weird with CSS (as it usually does), but I suspect this is a net improvement.

Much appreciated @ramlakhanmadheshiya!

@cpcloud cpcloud changed the title fix: dropdowns in navigation bar docs(dropdowns): make dropdowns scrollable and easier to see in navigation bar Sep 12, 2024
@cpcloud cpcloud merged commit c8932c8 into ibis-project:main Sep 12, 2024
18 checks passed
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants