fix(duckdb): support version 1.1.0 #10037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
tests
|
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
cpcloud
force-pushed
the
duckdb-1.1-fixes
branch
from
f8a0ecb to
dedac33
Compare
jcrist
approved these changes
Sep 6, 2024
| duckdb=["duckdb>=1.1"], | ||
| raises=AssertionError, | ||
| reason="not exact, even at this tiny scale", | ||
| ), |
There was a problem hiding this comment.
Don't need to handle it in this PR, but we should probably split any approx function tests out to test approximate results rather than just xfailing.
cpcloud
force-pushed
the
duckdb-1.1-fixes
branch
2 times, most recently
from
36f5061 to
411fd06
Compare
cpcloud
force-pushed
the
duckdb-1.1-fixes
branch
from
411fd06 to
d12c2c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes related to DuckDB 1.1. I am not sure why partitioning results in a different column ordering now. This is not ready for merge until DuckDB cuts an official release. Other than the partitioning question this is ready to go. Tests will fail until a release, because of the version number comparison being wonky due to the dev suffix.