Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose common public types in top-level namespace #8717

Closed
jcrist opened this issue Mar 20, 2024 · 0 comments · Fixed by #9008
Closed

feat: expose common public types in top-level namespace #8717

jcrist opened this issue Mar 20, 2024 · 0 comments · Fixed by #9008
Labels
ux User experience related issues

Comments

@jcrist
Copy link
Member

jcrist commented Mar 20, 2024 •
edited
Loading

When writing code consuming ibis objects as part of its api, I often want to write functions that take in ibis tables/columns/scalars/values. From a UX perspective it would be nice to export a few common types in the top-level namespace so I can refer to these types in both annotations and docs as ibis.Table instead of ibis.expr.types.Table.

For my use case ibis.Table and ibis.Column alone would be sufficient. For completeness exporting ibis.Scalar, ibis.Value, and maybe ibis.Deferred may also be nice.
@jcrist jcrist added the ux User experience related issues label Mar 20, 2024
@jcrist jcrist mentioned this issue Apr 18, 2024
Merged
cpcloud pushed a commit that referenced this issue Apr 19, 2024
@jcrist
feat(api): expose common types in the top-level ibis namespace (#9008)
3f3ed27 
Adds `Table`, `Column`, `Scalar`, `Value`, and `Deferred` to the
top-level `ibis` namespace. These are mostly useful for downstream users
consuming the ibis api (either type-annotating their code, or using
`isinstance` checks).

Fixes #8717.
@github-project-automation github-project-automation bot moved this from backlog to done in Ibis planning and roadmap Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ux User experience related issues
Projects
Ibis planning and roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api): expose common types in the top-level ibis namespace jcrist/ibis
1 participant
@jcrist