feat(api): expose the ability to refer to existing functions not defined in ibis APIs #7119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
feature
cpcloud
changed the title
cpcloud
force-pushed
the
builtin-udf
branch
2 times, most recently
from
91cb562 to
54398d8
Compare
cpcloud
changed the title
cpcloud
force-pushed
the
builtin-udf
branch
4 times, most recently
from
a670a11 to
9ec2623
Compare
cpcloud
force-pushed
the
builtin-udf
branch
4 times, most recently
from
81de075 to
a4a02cd
Compare
jcrist
reviewed
Sep 11, 2023
cpcloud
force-pushed
the
builtin-udf
branch
2 times, most recently
from
5e4c8ac to
68c97d9
Compare
cpcloud
force-pushed
the
builtin-udf
branch
from
68c97d9 to
0ba8913
Compare
kszucs
reviewed
Sep 11, 2023
|
|
||
|
|
||
| @udf.scalar.builtin(name="arrayJaccardIndex") | ||
| def array_jaccard_index(a: dt.Array[dt.int64], b: dt.Array[dt.int64]) -> float: |
There was a problem hiding this comment.
Datatype types should be the preferred spelling: dt.Array[dt.Int64], at least static type checkers will complain about the instances.
kszucs
reviewed
Sep 11, 2023
| from ibis import udf | ||
|
|
||
| @udf.scalar.builtin | ||
| def mismatches(left: str, right: str) -> int: |
There was a problem hiding this comment.
Do we need a note about annotations being optional? There is a separate PR for that.
kszucs
approved these changes
Sep 12, 2023
5 tasks
5 tasks
|
This is super useful! Nice walkthrough writeup, that really is going to mean this gets used more. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes our already-existing opaque UDFs (renamed to
builtinhere), and adds tests for the API.Draft mode until I add tests for more backends.