Skip to content

Commit

Permalink
test(clickhouse): xfail on broken sqlglot functionality
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed May 26, 2024
1 parent 94c53ef commit e82aebf
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions ibis/backends/clickhouse/tests/test_datatypes.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
import hypothesis as h
import hypothesis.strategies as st
import pytest
import sqlglot as sg
import sqlglot.expressions as sge
from packaging.version import parse as vparse
from pytest import param

import ibis
Expand Down Expand Up @@ -192,6 +194,11 @@ def test_array_discovery_clickhouse(con):
),
nullable=False,
),
marks=pytest.mark.xfail(
vparse(sg.__version__) == vparse("24.0.0"),
reason="struct parsing for clickhouse broken in sqlglot 24",
raises=sg.ParseError,
),
id="named_tuple",
),
param(
Expand All @@ -203,6 +210,11 @@ def test_array_discovery_clickhouse(con):
),
nullable=False,
),
marks=pytest.mark.xfail(
vparse("24.0.0") <= vparse(sg.__version__) <= vparse("24.0.1"),
reason="struct parsing for clickhouse broken in sqlglot 24",
raises=sg.ParseError,
),
id="unnamed_tuple",
),
param(
Expand All @@ -214,6 +226,11 @@ def test_array_discovery_clickhouse(con):
),
nullable=False,
),
marks=pytest.mark.xfail(
vparse("24.0.0") <= vparse(sg.__version__) <= vparse("24.0.1"),
reason="struct parsing for clickhouse broken in sqlglot 24",
raises=sg.ParseError,
),
id="partially_named",
),
param(
Expand Down

0 comments on commit e82aebf

Please sign in to comment.