Skip to content

Commit

Permalink
test(clickhouse): enable non-equijoin xpassing test
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed Dec 20, 2024
1 parent 97ebca0 commit e118db1
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions ibis/backends/clickhouse/tests/test_select.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from pytest import param

import ibis
from ibis.backends.tests.errors import ClickHouseDatabaseError

cc = pytest.importorskip("clickhouse_connect")

Expand Down Expand Up @@ -189,16 +188,11 @@ def test_physical_table_reference_translate(alltypes, assert_sql):


def test_non_equijoin(alltypes):
t = alltypes.limit(100)
t = alltypes.limit(10)
t2 = t.view()
expr = t.join(t2, t.tinyint_col < t2.timestamp_col.minute()).count()

# compilation should pass
expr.compile()

# while execution should fail since clickhouse doesn't support non-equijoin
with pytest.raises(ClickHouseDatabaseError, match="INVALID_JOIN_ON_EXPRESSION"):
expr.execute()
count = expr.to_pandas()
assert count == 45


@pytest.mark.parametrize(
Expand Down

0 comments on commit e118db1

Please sign in to comment.