Skip to content

Commit

Permalink
test(sql): do more than a smoketest in test_literal()
Browse files Browse the repository at this point in the history
This still isn't much meat in this test, but it is a little more substantial now.
  • Loading branch information
NickCrews authored and jcrist committed Jun 7, 2024
1 parent c23e487 commit df34951
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions ibis/backends/tests/test_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
@pytest.mark.parametrize(
"expr",
[
param(ibis.literal(1), id="simple_literal"),
param(ibis.literal(432), id="simple_literal"),
param(
ibis.array([1]),
ibis.array([432]),
marks=[
pytest.mark.never(
["mysql", "mssql", "oracle", "impala", "sqlite"],
Expand All @@ -27,7 +27,7 @@
id="array_literal",
),
param(
ibis.struct(dict(a=1)),
ibis.struct(dict(abc=432)),
marks=[
pytest.mark.never(
["impala", "mysql", "sqlite", "mssql", "exasol"],
Expand All @@ -49,7 +49,7 @@
)
@pytest.mark.notimpl(["polars"], reason="Not clear how to extract SQL from the backend")
def test_literal(backend, expr):
assert ibis.to_sql(expr, dialect=backend.name())
assert "432" in ibis.to_sql(expr, dialect=backend.name())


@pytest.mark.never(["pandas", "dask", "polars"], reason="not SQL")
Expand Down

0 comments on commit df34951

Please sign in to comment.