Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud authored Jun 24, 2024
1 parent 59d4d23 commit dd1be07
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion ibis/backends/dask/executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ def visit(cls, op: ops.Sort, parent, keys):
elif not any(nulls_first):
na_position = "last"
else:
raise ValueError("dask does not support different columns ordering")
raise ValueError("dask does not support specifying null ordering for individual columns")

newcols = {gen_name("sort_key"): col for col in keys}
names = list(newcols.keys())
Expand Down
2 changes: 1 addition & 1 deletion ibis/backends/pandas/executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ def visit(cls, op: ops.Sort, parent, keys):
elif not any(nulls_first):
na_position = "last"
else:
raise ValueError("pandas does not support different columns ordering")
raise ValueError("pandas does not support specifying null ordering for individual columns")

newcols = {gen_name("sort_key"): col for col in keys}
names = list(newcols.keys())
Expand Down

0 comments on commit dd1be07

Please sign in to comment.