Skip to content

Commit

Permalink
test(flink): revise WIP marks in aggregation tests
Browse files Browse the repository at this point in the history
  • Loading branch information
deepyaman authored and gforsyth committed Nov 6, 2023
1 parent d36ed1c commit d87bd8f
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions ibis/backends/tests/test_aggregation.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ def mean_udf(s):
"trino",
"druid",
"oracle",
"flink",
],
raises=com.OperationNotDefinedError,
),
Expand All @@ -75,7 +76,6 @@ def mean_udf(s):
reason="no udf support",
raises=com.OperationNotDefinedError,
),
pytest.mark.notimpl(["flink"], "WIP", raises=com.OperationNotDefinedError),
],
),
param(lambda t: t.double_col.min(), lambda t: t.double_col.min(), id="min"),
Expand All @@ -98,10 +98,10 @@ def mean_udf(s):
"trino",
"druid",
"oracle",
"flink",
],
raises=com.OperationNotDefinedError,
),
pytest.mark.notimpl(["flink"], "WIP", raises=com.OperationNotDefinedError),
],
),
param(
Expand Down Expand Up @@ -130,15 +130,13 @@ def mean_udf(s):
"mssql",
"druid",
"oracle",
"flink",
]
argidx_grouped_marks = ["dask"] + argidx_not_grouped_marks


def make_argidx_params(marks):
marks = [
pytest.mark.notyet(marks, raises=com.OperationNotDefinedError),
pytest.mark.notimpl(["flink"], "WIP", raises=com.OperationNotDefinedError),
]
marks = pytest.mark.notyet(marks, raises=com.OperationNotDefinedError)
return [
param(
lambda t: t.timestamp_col.argmin(t.id),
Expand Down

0 comments on commit d87bd8f

Please sign in to comment.