test(duckdb): enable xpassing tests; new xfails

ibis-project · Apr 22, 2024 · caa113b · caa113b
1 parent cdd2e68
commit caa113b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/ibis/backends/duckdb/tests/test_register.py b/ibis/backends/duckdb/tests/test_register.py
@@ -472,7 +472,9 @@ def test_csv_with_slash_n_null(con, tmp_path):
             ["httpfs"],
             marks=[
                 pytest.mark.xfail(
-                    parse_version(duckdb.__version__) >= parse_version("0.10.0"),
+                    parse_version("0.10.0")
+                    <= parse_version(duckdb.__version__)
+                    < parse_version("0.10.2"),
                     reason="https://github.com/duckdb/duckdb/issues/10698",
                     raises=duckdb.HTTPException,
                 )

diff --git a/ibis/backends/tests/test_asof_join.py b/ibis/backends/tests/test_asof_join.py
@@ -7,6 +7,7 @@
 import pytest
 
 import ibis
+from ibis.backends.tests.errors import DuckDBInvalidInputException
 
 
 @pytest.fixture(scope="module")
@@ -141,6 +142,9 @@ def test_asof_join(con, time_left, time_right, time_df1, time_df2, direction, op
         "flink",
     ]
 )
+@pytest.mark.xfail_version(
+    duckdb=["duckdb>=0.10.2"], raises=DuckDBInvalidInputException
+)
 def test_keyed_asof_join_with_tolerance(
     con,
     time_keyed_left,

diff --git a/ibis/backends/tests/test_temporal.py b/ibis/backends/tests/test_temporal.py
@@ -1133,7 +1133,7 @@ def test_timestamp_comparison_filter(backend, con, alltypes, df, func_name):
         reason="Invalid comparison between dtype=datetime64[ns, UTC] and datetime",
     ),
     pytest.mark.xfail_version(
-        duckdb=["duckdb>=0.10"],
+        duckdb=["duckdb>=0.10,<0.10.2"],
         raises=DuckDBBinderException,
         # perhaps we should consider disallowing this in ibis as well
         reason="DuckDB doesn't allow comparing timestamp with and without timezones starting at version 0.10",