Skip to content

Commit

Permalink
chore(ci): add todo note about restoring the previous ci-check command
Browse files Browse the repository at this point in the history
  • Loading branch information
kszucs committed Dec 14, 2023
1 parent aa005e5 commit b5355a4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ibis-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ jobs:

- name: run all core tests and run benchmarks once parallel
if: matrix.os != 'windows-latest'
# TODO(kszucs): restore "just ci-check -m "'core or benchmark'" -n auto"
run: poetry run pytest -v -n auto ibis/common ibis/expr ibis/tests ibis/formats

- name: run all core tests and run benchmarks once serial
Expand Down
5 changes: 3 additions & 2 deletions ibis/backends/base/sql/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,9 @@ def table(self, name: str, database: str | None = None) -> ir.Table:
)
qualified_name = self._fully_qualified_name(name, database)
schema = self.get_schema(qualified_name)
namespace = ops.Namespace(database=database)
node = ops.DatabaseTable(name, schema, self, namespace=namespace)
node = ops.DatabaseTable(
name, schema, self, namespace=ops.Namespace(database=database)
)
return node.to_expr()

def _fully_qualified_name(self, name, database):
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/pandas/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@
if TYPE_CHECKING:
from collections.abc import Iterable, Mapping


integer_types = np.integer, int
floating_types = (numbers.Real,)
numeric_types = integer_types + floating_types
Expand Down

0 comments on commit b5355a4

Please sign in to comment.