Skip to content

Commit

Permalink
chore(flink): remove xfails now that flink passes
Browse files Browse the repository at this point in the history
  • Loading branch information
NickCrews committed Oct 29, 2024
1 parent 8df3d9c commit b461b4c
Showing 1 changed file with 0 additions and 41 deletions.
41 changes: 0 additions & 41 deletions ibis/backends/tests/test_numeric.py
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,6 @@ def test_binary_arithmetic_operations(backend, alltypes, df, op):
backend.assert_series_equal(result, expected, check_exact=False)


@pytest.mark.notimpl("flink", raises=AssertionError, reason="Flink does floor division")
def test_integer_truediv(con):
expr = 1 / ibis.literal(2)
result = con.execute(expr)
Expand Down Expand Up @@ -1149,11 +1148,6 @@ def test_floating_mod(backend, alltypes, df):
raises=OracleDatabaseError,
reason="Oracle doesn't do integer division by zero",
),
pytest.mark.notyet(
"flink",
raises=Py4JJavaError,
reason="Flink doesn't do integer division by zero",
),
],
),
param(
Expand All @@ -1165,11 +1159,6 @@ def test_floating_mod(backend, alltypes, df):
raises=OracleDatabaseError,
reason="Oracle doesn't do integer division by zero",
),
pytest.mark.notyet(
"flink",
raises=Py4JJavaError,
reason="Flink doesn't do integer division by zero",
),
],
),
param(
Expand All @@ -1181,11 +1170,6 @@ def test_floating_mod(backend, alltypes, df):
raises=OracleDatabaseError,
reason="Oracle doesn't do integer division by zero",
),
pytest.mark.notyet(
"flink",
raises=Py4JJavaError,
reason="Flink doesn't do integer division by zero",
),
],
),
param(
Expand All @@ -1197,11 +1181,6 @@ def test_floating_mod(backend, alltypes, df):
raises=OracleDatabaseError,
reason="Oracle doesn't do integer division by zero",
),
pytest.mark.notyet(
"flink",
raises=Py4JJavaError,
reason="Flink doesn't do integer division by zero",
),
],
),
param("float_col", 0),
Expand All @@ -1216,11 +1195,6 @@ def test_floating_mod(backend, alltypes, df):
reason="Oracle doesn't do integer division by zero",
),
pytest.mark.never(["impala"], reason="doesn't allow divide by zero"),
pytest.mark.notyet(
"flink",
raises=Py4JJavaError,
reason="Flink doesn't do integer division by zero",
),
],
),
param(
Expand All @@ -1233,11 +1207,6 @@ def test_floating_mod(backend, alltypes, df):
reason="Oracle doesn't do integer division by zero",
),
pytest.mark.never(["impala"], reason="doesn't allow divide by zero"),
pytest.mark.notyet(
"flink",
raises=Py4JJavaError,
reason="Flink doesn't do integer division by zero",
),
],
),
param(
Expand All @@ -1250,11 +1219,6 @@ def test_floating_mod(backend, alltypes, df):
reason="Oracle doesn't do integer division by zero",
),
pytest.mark.never(["impala"], reason="doesn't allow divide by zero"),
pytest.mark.notyet(
"flink",
raises=Py4JJavaError,
reason="Flink doesn't do integer division by zero",
),
],
),
param(
Expand All @@ -1267,11 +1231,6 @@ def test_floating_mod(backend, alltypes, df):
reason="Oracle doesn't do integer division by zero",
),
pytest.mark.never(["impala"], reason="doesn't allow divide by zero"),
pytest.mark.notyet(
"flink",
raises=Py4JJavaError,
reason="Flink doesn't do integer division by zero",
),
],
),
param(
Expand Down

0 comments on commit b461b4c

Please sign in to comment.