chore: handle joins with no user-provided predicates

ibis-project · Dec 26, 2023 · 9b4c739 · 9b4c739
1 parent ff35399
commit 9b4c739
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/ibis/backends/base/sqlglot/compiler.py b/ibis/backends/base/sqlglot/compiler.py
@@ -924,8 +924,7 @@ def visit_JoinLink(self, op, *, how, table, predicates):
             "cross": "cross",
             "outer": "outer",
         }
-        if not predicates:
-            predicates += (True,)
+        assert predicates
         return sge.Join(
             this=table, side=sides[how], kind=kinds[how], on=sg.and_(*predicates)
         )

diff --git a/ibis/expr/types/joins.py b/ibis/expr/types/joins.py
@@ -185,6 +185,11 @@ def join(
         )
         preds = flatten_predicates(list(preds))
 
+        # if there are no predicates, default to every row matching unless the
+        # join is a cross join, because a cross join already has this behavior
+        if not preds and how != "cross":
+            preds.append(ops.Literal(True, dtype="bool"))
+
         # calculate the fields based in lname and rname, this should be a best
         # effort to avoid collisions, but does not raise if there are any
         # if no disambiaution happens using a final .select() call, then