feat(snowflake): use upstream array_sort

ibis-project · Nov 19, 2023 · 9624341 · 9624341
1 parent 186b61e
commit 9624341
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/ibis/backends/snowflake/__init__.py b/ibis/backends/snowflake/__init__.py
@@ -110,11 +110,6 @@ class SnowflakeCompiler(AlchemyCompiler):
     return Object.assign(...keys.map((key, j) => ({[key]: arrays[j][i]})));
 })""",
     },
-    "ibis_udfs.public.array_sort": {
-        "inputs": {"array": ARRAY},
-        "returns": ARRAY,
-        "source": """return array.sort();""",
-    },
     "ibis_udfs.public.array_repeat": {
         # Integer inputs are not allowed because JavaScript only supports
         # doubles

diff --git a/ibis/backends/snowflake/registry.py b/ibis/backends/snowflake/registry.py
@@ -420,7 +420,7 @@ def _timestamp_bucket(t, op):
         ops.ArrayRemove: fixed_arity(sa.func.array_remove, 2),
         ops.ArrayIntersect: fixed_arity(sa.func.array_intersection, 2),
         ops.ArrayZip: _array_zip,
-        ops.ArraySort: unary(sa.func.ibis_udfs.public.array_sort),
+        ops.ArraySort: unary(sa.func.array_sort),
         ops.ArrayRepeat: fixed_arity(sa.func.ibis_udfs.public.array_repeat, 2),
         ops.StringSplit: fixed_arity(sa.func.split, 2),
         # snowflake typeof only accepts VARIANT, so we cast