Skip to content

Commit

Permalink
test(backends): remove now unused supports_window_operations backen…
Browse files Browse the repository at this point in the history
…d flag (#8932)

Test case configuration now happens through pytest markers.
  • Loading branch information
kszucs authored Apr 11, 2024
1 parent fdbe67c commit 8553915
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 9 deletions.
1 change: 0 additions & 1 deletion ibis/backends/clickhouse/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

class TestConf(ServiceBackendTest):
check_dtype = False
supports_window_operations = False
returned_timestamp_unit = "s"
supported_to_timestamp_units = {"s"}
supports_floating_modulus = False
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/druid/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ def run_query(session: Session, query: str) -> None:
class TestConf(ServiceBackendTest):
# druid has the same rounding behavior as postgres
check_dtype = False
supports_window_operations = False
returned_timestamp_unit = "s"
supports_arrays = False
supports_arrays_outside_of_select = supports_arrays
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/exasol/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ class TestConf(ServiceBackendTest):
check_names = False
supports_arrays = False
supports_arrays_outside_of_select = supports_arrays
supports_window_operations = True
supports_divide_by_zero = False
returned_timestamp_unit = "us"
supported_to_timestamp_units = {"s", "ms", "us"}
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/mssql/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
class TestConf(ServiceBackendTest):
# MSSQL has the same rounding behavior as postgres
check_dtype = False
supports_window_operations = False
returned_timestamp_unit = "s"
supports_arrays_outside_of_select = supports_arrays = False
supports_structs = False
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/mysql/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ class TestConf(ServiceBackendTest):
rounding_method = "half_to_even"
service_name = "mysql"
deps = ("pymysql",)
supports_window_operations = True

@property
def test_files(self) -> Iterable[Path]:
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/oracle/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@

class TestConf(ServiceBackendTest):
check_dtype = False
supports_window_operations = False
returned_timestamp_unit = "s"
supports_arrays = False
supports_arrays_outside_of_select = False
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/sqlite/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
class TestConf(BackendTest):
supports_arrays = False
supports_arrays_outside_of_select = supports_arrays
supports_window_operations = True
check_dtype = False
returned_timestamp_unit = "s"
supports_structs = False
Expand Down
2 changes: 0 additions & 2 deletions ibis/backends/tests/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ class BackendTest(abc.ABC):
"Whether backend supports Arrays / Lists"
supports_arrays_outside_of_select: bool = supports_arrays
"Whether backend supports Arrays / Lists outside of Select Statements"
supports_window_operations: bool = True
"Whether backend supports Window Operations"
supports_divide_by_zero: bool = False
"Whether backend supports division by zero"
returned_timestamp_unit: str = "us"
Expand Down

0 comments on commit 8553915

Please sign in to comment.