fix(sql): remove constants in order_by calls during select merging (#…

…10475)

Remove literals in `ORDER BY` when sorting tables. Fixes #10428.

ibis/backends/sql/rewrites.py

@@ -320,7 +320,9 @@ def merge_select_select(_, **kwargs):
         selections=selections,
         predicates=unique_predicates,
         qualified=unique_qualified,
-        sort_keys=unique_sort_keys,
+        sort_keys=tuple(
+            key for key in unique_sort_keys if not isinstance(key.expr, ops.Literal)
+        ),
         distinct=distinct,
     )
     return result if complexity(result) <= complexity(_) else _

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/bigquery/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  `t0`.`a`,
+  9 AS `i`,
+  'foo' AS `s`
+FROM `test` AS `t0`
+ORDER BY
+  `t0`.`a` ASC NULLS LAST

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/clickhouse/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  "t0"."a" AS "a",
+  9 AS "i",
+  'foo' AS "s"
+FROM "test" AS "t0"
+ORDER BY
+  "t0"."a" ASC

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/databricks/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  `t0`.`a`,
+  9 AS `i`,
+  'foo' AS `s`
+FROM `test` AS `t0`
+ORDER BY
+  `t0`.`a` ASC NULLS LAST

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/datafusion/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  "t0"."a",
+  9 AS "i",
+  'foo' AS "s"
+FROM "test" AS "t0"
+ORDER BY
+  "t0"."a" ASC

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/druid/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  "t0"."a",
+  9 AS "i",
+  'foo' AS "s"
+FROM "test" AS "t0"
+ORDER BY
+  "t0"."a" ASC

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/duckdb/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  "t0"."a",
+  9 AS "i",
+  'foo' AS "s"
+FROM "test" AS "t0"
+ORDER BY
+  "t0"."a" ASC

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/exasol/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  "t0"."a",
+  9 AS "i",
+  'foo' AS "s"
+FROM "test" AS "t0"
+ORDER BY
+  "t0"."a" ASC

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/flink/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  `t0`.`a`,
+  9 AS `i`,
+  'foo' AS `s`
+FROM `test` AS `t0`
+ORDER BY
+  `t0`.`a` ASC NULLS LAST

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/impala/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  `t0`.`a`,
+  9 AS `i`,
+  'foo' AS `s`
+FROM `test` AS `t0`
+ORDER BY
+  `t0`.`a` ASC

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/mssql/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  [t0].[a],
+  9 AS [i],
+  'foo' AS [s]
+FROM [test] AS [t0]
+ORDER BY
+  CASE WHEN [t0].[a] IS NULL THEN 1 ELSE 0 END, [t0].[a] ASC

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/mysql/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  `t0`.`a`,
+  9 AS `i`,
+  'foo' AS `s`
+FROM `test` AS `t0`
+ORDER BY
+  CASE WHEN `t0`.`a` IS NULL THEN 1 ELSE 0 END, `t0`.`a` ASC

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/oracle/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  "t0"."a",
+  9 AS "i",
+  'foo' AS "s"
+FROM "test" "t0"
+ORDER BY
+  "t0"."a" ASC

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/postgres/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  "t0"."a",
+  9 AS "i",
+  'foo' AS "s"
+FROM "test" AS "t0"
+ORDER BY
+  "t0"."a" ASC

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/pyspark/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  `t0`.`a`,
+  9 AS `i`,
+  'foo' AS `s`
+FROM `test` AS `t0`
+ORDER BY
+  `t0`.`a` ASC NULLS LAST

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/risingwave/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  "t0"."a",
+  9 AS "i",
+  'foo' AS "s"
+FROM "test" AS "t0"
+ORDER BY
+  "t0"."a" ASC

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/snowflake/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  "t0"."a",
+  9 AS "i",
+  'foo' AS "s"
+FROM "test" AS "t0"
+ORDER BY
+  "t0"."a" ASC

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/sqlite/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  "t0"."a",
+  9 AS "i",
+  'foo' AS "s"
+FROM "test" AS "t0"
+ORDER BY
+  "t0"."a" ASC NULLS LAST

ibis/backends/tests/snapshots/test_sql/test_order_by_no_deference_literals/trino/out.sql

@@ -0,0 +1,7 @@
+SELECT
+  "t0"."a",
+  9 AS "i",
+  'foo' AS "s"
+FROM "test" AS "t0"
+ORDER BY
+  "t0"."a" ASC

ibis/backends/tests/test_sql.py

@@ -259,3 +259,13 @@ def test_sample(backend_name, snapshot, subquery):
     row = ibis.to_sql(t.sample(0.5, method="row"), dialect=backend_name)
     snapshot.assert_match(block, "block.sql")
     snapshot.assert_match(row, "row.sql")
+
+
+@pytest.mark.parametrize("backend_name", _get_backends_to_test())
+@pytest.mark.notimpl(["polars"], raises=ValueError, reason="not a SQL backend")
+def test_order_by_no_deference_literals(backend_name, snapshot):
+    t = ibis.table({"a": "int"}, name="test")
+    s = t.select("a", i=ibis.literal(9), s=ibis.literal("foo"))
+    o = s.order_by("a", "i", "s")
+    sql = ibis.to_sql(o, dialect=backend_name)
+    snapshot.assert_match(sql, "out.sql")