refactor(snowflake): adjust window frames to use _minimize_spec due…

… to upstream snowflake changes

ibis/backends/snowflake/compiler.py

@@ -70,6 +70,17 @@ def _aggregate(self, funcname: str, *args, where):
     def visit_node(self, op, **kw):
         return super().visit_node(op, **kw)
 
+    @staticmethod
+    def _minimize_spec(start, end, spec):
+        if (
+            start is None
+            and isinstance(getattr(end, "value", None), ops.Literal)
+            and end.value.value == 0
+            and end.following
+        ):
+            return None
+        return spec
+
     @visit_node.register(ops.Literal)
     def visit_Literal(self, op, *, value, dtype):
         if value is None:

ibis/backends/tests/snapshots/test_generic/test_many_subqueries/snowflake/out.sql

@@ -1,15 +1,15 @@
 WITH "t6" AS (
   SELECT
     "t5"."street",
-    ROW_NUMBER() OVER (ORDER BY "t5"."street" ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) - 1 AS "key"
+    ROW_NUMBER() OVER (ORDER BY "t5"."street" ASC) - 1 AS "key"
   FROM (
     SELECT
       "t2"."street",
       "t2"."key"
     FROM (
       SELECT
         "t0"."street",
-        ROW_NUMBER() OVER (ORDER BY "t0"."street" ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) - 1 AS "key"
+        ROW_NUMBER() OVER (ORDER BY "t0"."street" ASC) - 1 AS "key"
       FROM "data" AS "t0"
     ) AS "t2"
     INNER JOIN (
@@ -18,7 +18,7 @@ WITH "t6" AS (
       FROM (
         SELECT
           "t0"."street",
-          ROW_NUMBER() OVER (ORDER BY "t0"."street" ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) - 1 AS "key"
+          ROW_NUMBER() OVER (ORDER BY "t0"."street" ASC) - 1 AS "key"
         FROM "data" AS "t0"
       ) AS "t1"
     ) AS "t4"
@@ -27,7 +27,7 @@ WITH "t6" AS (
 ), "t1" AS (
   SELECT
     "t0"."street",
-    ROW_NUMBER() OVER (ORDER BY "t0"."street" ASC ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) - 1 AS "key"
+    ROW_NUMBER() OVER (ORDER BY "t0"."street" ASC) - 1 AS "key"
   FROM "data" AS "t0"
 )
 SELECT