Skip to content

Commit

Permalink
test(backends): remove now unused supports_arrays_outside_of_select
Browse files Browse the repository at this point in the history
… backend flag (#8935)

Test case configuration now happens through pytest markers.
  • Loading branch information
kszucs authored Apr 11, 2024
1 parent 5095349 commit 37ffa94
Show file tree
Hide file tree
Showing 8 changed files with 2 additions and 9 deletions.
1 change: 0 additions & 1 deletion ibis/backends/druid/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ class TestConf(ServiceBackendTest):
check_dtype = False
returned_timestamp_unit = "s"
supports_arrays = False
supports_arrays_outside_of_select = supports_arrays
native_bool = True
supports_structs = False
supports_json = False # it does, but we haven't implemented it
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/exasol/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ class TestConf(ServiceBackendTest):
check_dtype = False
check_names = False
supports_arrays = False
supports_arrays_outside_of_select = supports_arrays
supports_divide_by_zero = False
returned_timestamp_unit = "us"
supported_to_timestamp_units = {"s", "ms", "us"}
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/impala/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

class TestConf(BackendTest):
supports_arrays = True
supports_arrays_outside_of_select = False
check_dtype = False
supports_divide_by_zero = True
returned_timestamp_unit = "s"
Expand Down
2 changes: 1 addition & 1 deletion ibis/backends/mssql/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class TestConf(ServiceBackendTest):
# MSSQL has the same rounding behavior as postgres
check_dtype = False
returned_timestamp_unit = "s"
supports_arrays_outside_of_select = supports_arrays = False
supports_arrays = False
supports_structs = False
supports_json = False
rounding_method = "half_to_even"
Expand Down
2 changes: 1 addition & 1 deletion ibis/backends/mysql/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class TestConf(ServiceBackendTest):
# mysql has the same rounding behavior as postgres
check_dtype = False
returned_timestamp_unit = "s"
supports_arrays = supports_arrays_outside_of_select = False
supports_arrays = False
native_bool = False
supports_structs = False
rounding_method = "half_to_even"
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/oracle/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ class TestConf(ServiceBackendTest):
check_dtype = False
returned_timestamp_unit = "s"
supports_arrays = False
supports_arrays_outside_of_select = False
# Automatic mutate so that logical type in ibis returns as bool
# but the backend will still do whatever it's going to do
native_bool = False
Expand Down
1 change: 0 additions & 1 deletion ibis/backends/sqlite/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

class TestConf(BackendTest):
supports_arrays = False
supports_arrays_outside_of_select = supports_arrays
check_dtype = False
returned_timestamp_unit = "s"
supports_structs = False
Expand Down
2 changes: 0 additions & 2 deletions ibis/backends/tests/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ class BackendTest(abc.ABC):
"Check that column name matches when comparing Pandas Series"
supports_arrays: bool = True
"Whether backend supports Arrays / Lists"
supports_arrays_outside_of_select: bool = supports_arrays
"Whether backend supports Arrays / Lists outside of Select Statements"
supports_divide_by_zero: bool = False
"Whether backend supports division by zero"
returned_timestamp_unit: str = "us"
Expand Down

0 comments on commit 37ffa94

Please sign in to comment.