chore(deps): bump 3.12 usage to 3.13 (#10588)

Bumps most usage of 3.12 to 3.13 in CI.
ibis-project · Dec 17, 2024 · 2d46fbb · 2d46fbb
1 parent aa60584
commit 2d46fbb
Show file tree

Hide file tree

Showing 10 changed files with 101 additions and 22 deletions.
diff --git a/.github/workflows/check-generated-files.yml b/.github/workflows/check-generated-files.yml
@@ -39,7 +39,7 @@ jobs:
         uses: actions/setup-python@v5
         id: install_python
         with:
-          python-version: "3.12"
+          python-version: "3.13"
           cache: pip
           cache-dependency-path: requirements-dev.txt
 

diff --git a/.github/workflows/ibis-backends-cloud.yml b/.github/workflows/ibis-backends-cloud.yml
@@ -41,7 +41,7 @@ jobs:
       matrix:
         python-version:
           - "3.10"
-          - "3.12"
+          - "3.13"
         backend:
           - name: snowflake
             title: Snowflake
@@ -58,7 +58,7 @@ jobs:
               title: BigQuery
               extras:
                 - --extra bigquery
-          - python-version: "3.12"
+          - python-version: "3.13"
             backend:
               name: bigquery
               title: BigQuery

diff --git a/.github/workflows/ibis-backends.yml b/.github/workflows/ibis-backends.yml
@@ -53,7 +53,7 @@ jobs:
           - windows-latest
         python-version:
           - "3.10"
-          - "3.12"
+          - "3.13"
     steps:
       - name: checkout
         uses: actions/checkout@v4
@@ -95,7 +95,7 @@ jobs:
           - windows-latest
         python-version:
           - "3.10"
-          - "3.12"
+          - "3.13"
         backend:
           - name: duckdb
             title: DuckDB
@@ -258,7 +258,42 @@ jobs:
               sys-deps:
                 - cmake
                 - ninja-build
+          # pytorch wheel doesn't exist for windows + python 3.13, so test
+          # against 3.12 until that's shipped
+          - os: windows-latest
+            python-version: "3.12"
+            backend:
+              name: duckdb
+              title: DuckDB
+              serial: true
+              extras:
+                - --extra duckdb
+                - --extra deltalake
+                - --extra geospatial
+                - --extra examples
+                - --extra decompiler
+                - --extra polars
+            additional_deps:
+              - torch
+          # also test duckdb with python 3.13 on windows, *without* pytorch
+          - os: windows-latest
+            python-version: "3.13"
+            backend:
+              name: duckdb
+              title: DuckDB
+              serial: true
+              extras:
+                - --extra duckdb
+                - --extra deltalake
+                - --extra geospatial
+                - --extra examples
+                - --extra decompiler
+                - --extra polars
         exclude:
+          - os: windows-latest
+            python-version: "3.13"
+            backend:
+              name: duckdb
           - os: windows-latest
             backend:
               name: mysql
@@ -317,7 +352,7 @@ jobs:
                 - libgeos-dev
           # TODO(deepyaman): Test whether this works upon releasing https://github.com/cloudera/impyla/commit/bf1f94c3c4106ded6267d2485c1e939775a6a87f
           - os: ubuntu-latest
-            python-version: "3.12"
+            python-version: "3.13"
             backend:
               name: impala
               title: Impala
@@ -383,7 +418,7 @@ jobs:
               services:
                 - oracle
           - os: ubuntu-latest
-            python-version: "3.12"
+            python-version: "3.13"
             backend:
               name: flink
               title: Flink
@@ -526,7 +561,7 @@ jobs:
             tag: local
             deps:
               - delta-spark==3.2.1
-          - python-version: "3.12"
+          - python-version: "3.13"
             pyspark-minor-version: "3.5"
             tag: local
             deps:

diff --git a/.github/workflows/ibis-main.yml b/.github/workflows/ibis-main.yml
@@ -49,6 +49,7 @@ jobs:
           - "3.10"
           - "3.11"
           - "3.12"
+          - "3.13"
         pyarrow:
           - true
           - false
@@ -118,7 +119,7 @@ jobs:
         uses: actions/setup-python@v5
         id: install_python
         with:
-          python-version: "3.12"
+          python-version: "3.13"
 
       - name: install uv
         uses: astral-sh/[email protected]

diff --git a/.github/workflows/pre-release.yml b/.github/workflows/pre-release.yml
@@ -27,7 +27,7 @@ jobs:
       - name: install python
         uses: actions/setup-python@v5
         with:
-          python-version: "3.12"
+          python-version: "3.13"
 
       - name: install uv
         uses: astral-sh/[email protected]

diff --git a/flake.lock b/flake.lock
diff --git a/ibis/backends/sql/compilers/bigquery/udf/core.py b/ibis/backends/sql/compilers/bigquery/udf/core.py
@@ -8,6 +8,7 @@
 import inspect
 import textwrap
 from collections import ChainMap
+from inspect import _empty as EMPTY
 from typing import TYPE_CHECKING
 
 from ibis.backends.sql.compilers.bigquery.udf.find import find_names
@@ -66,7 +67,7 @@ def wrapper(*args, **kwargs):
     return wrapper
 
 
-@rewrite.register(ast.Call(func=ast.Name(id="print")))
+@rewrite.register(ast.Call(func=ast.Name(id="print"), args=EMPTY, keywords=EMPTY))
 def rewrite_print(node):
     return ast.Call(
         func=ast.Attribute(
@@ -79,13 +80,15 @@ def rewrite_print(node):
     )
 
 
-@rewrite.register(ast.Call(func=ast.Name(id="len")))
+@rewrite.register(ast.Call(func=ast.Name(id="len"), args=EMPTY, keywords=EMPTY))
 def rewrite_len(node):
     assert len(node.args) == 1
     return ast.Attribute(value=node.args[0], attr="length", ctx=ast.Load())
 
 
-@rewrite.register(ast.Call(func=ast.Attribute(attr="append", value=None)))
+@rewrite.register(
+    ast.Call(func=ast.Attribute(attr="append", value=None), args=EMPTY, keywords=EMPTY)
+)
 def rewrite_append(node):
     return ast.Call(
         func=ast.Attribute(value=node.func.value, attr="push", ctx=ast.Load()),
@@ -95,7 +98,11 @@ def rewrite_append(node):
 
 
 @rewrite.register(
-    ast.Call(func=ast.Attribute(value=ast.Name(id="Array"), attr="from_"))
+    ast.Call(
+        func=ast.Attribute(value=ast.Name(id="Array"), attr="from_"),
+        args=EMPTY,
+        keywords=EMPTY,
+    )
 )
 def rewrite_array_from(node):
     return ast.Call(

diff --git a/ibis/backends/sql/compilers/bigquery/udf/rewrite.py b/ibis/backends/sql/compilers/bigquery/udf/rewrite.py
@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import ast
+from inspect import _empty as EMPTY
 from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
@@ -20,7 +21,7 @@ def matches(value: ast.AST, pattern: ast.AST) -> bool:
     fields = [
         (field, getattr(pattern, field))
         for field in pattern._fields
-        if hasattr(pattern, field)
+        if hasattr(pattern, field) and getattr(pattern, field) is not EMPTY
     ]
     return all(
         matches(getattr(value, field_name), field_value)

diff --git a/requirements-dev.txt b/requirements-dev.txt