test: add xfail for things that require inner join convenience

ibis-project · Dec 22, 2023 · 2ceb7f5 · 2ceb7f5
1 parent aea324c
commit 2ceb7f5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/ibis/backends/duckdb/tests/test_client.py b/ibis/backends/duckdb/tests/test_client.py
@@ -189,6 +189,7 @@ def test_insert(con):
     assert t.count().execute() == 2
 
 
+@pytest.mark.xfail(reason="snowflake backend not yet rewritten")
 def test_to_other_sql(con, snapshot):
     pytest.importorskip("snowflake.connector")
 

diff --git a/ibis/backends/tests/test_generic.py b/ibis/backends/tests/test_generic.py
@@ -1016,6 +1016,9 @@ def test_memtable_column_naming_mismatch(backend, con, monkeypatch, df, columns)
         ibis.memtable(df, columns=columns)
 
 
+@pytest.mark.xfail(
+    raises=com.IntegrityError, reason="inner join convenience not implemented"
+)
 @pytest.mark.notimpl(
     ["dask", "pandas", "polars"], raises=NotImplementedError, reason="not a SQL backend"
 )

diff --git a/ibis/backends/tests/test_sql.py b/ibis/backends/tests/test_sql.py
@@ -92,6 +92,9 @@ def test_group_by_has_index(backend, snapshot):
     snapshot.assert_match(sql, "out.sql")
 
 
+@pytest.mark.xfail(
+    raises=exc.IntegrityError, reason="inner join convenience not implemented"
+)
 @pytest.mark.never(["pandas", "dask", "polars", "pyspark"], reason="not SQL")
 def test_cte_refs_in_topo_order(backend, snapshot):
     mr0 = ibis.table(schema=ibis.schema(dict(key="int")), name="leaf")