Skip to content

Commit

Permalink
chore(polars): enable xpassing dot-sql tests
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed Apr 14, 2024
1 parent 92612f8 commit 21d9da2
Showing 1 changed file with 2 additions and 14 deletions.
16 changes: 2 additions & 14 deletions ibis/backends/tests/test_dot_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,6 @@ def test_con_dot_sql(backend, con, schema):
backend.assert_series_equal(result.astype(expected.dtype), expected)


@pytest.mark.notyet(
["polars"],
raises=PolarsComputeError,
reason="polars doesn't support quoted identifiers referencing CTEs",
)
@pytest.mark.notyet(
["bigquery"], raises=GoogleBadRequest, reason="requires a qualified name"
)
Expand Down Expand Up @@ -123,10 +118,11 @@ def test_table_dot_sql(backend):
assert pytest.approx(result) == expected


@dot_sql_never
@pytest.mark.notyet(
["polars"],
raises=PolarsComputeError,
reason="polars doesn't support quoted identifiers referencing CTEs",
reason="polars doesn't support aliased tables",
)
@pytest.mark.notyet(
["bigquery"], raises=GoogleBadRequest, reason="requires a qualified name"
Expand All @@ -139,7 +135,6 @@ def test_table_dot_sql(backend):
OracleDatabaseError,
reason="oracle doesn't know which of the tables in the join to sort from",
)
@dot_sql_never
def test_table_dot_sql_with_join(backend):
alltypes = backend.functional_alltypes
t = (
Expand Down Expand Up @@ -185,7 +180,6 @@ def test_table_dot_sql_with_join(backend):
backend.assert_frame_equal(result, expected)


@pytest.mark.notyet(["polars"], raises=PolarsComputeError)
@pytest.mark.notyet(["druid"], reason="druid doesn't respect column name case")
@pytest.mark.notyet(
["bigquery"], raises=GoogleBadRequest, reason="requires a qualified name"
Expand Down Expand Up @@ -242,7 +236,6 @@ def test_dot_sql_reuse_alias_with_different_types(backend, alltypes, df):


@pytest.mark.parametrize("dialect", dialects)
@pytest.mark.notyet(["polars"], raises=PolarsComputeError)
@dot_sql_never
@pytest.mark.notyet(["druid"], reason="druid doesn't respect column name case")
def test_table_dot_sql_transpile(backend, alltypes, dialect, df):
Expand Down Expand Up @@ -323,11 +316,6 @@ def mem_t(con):


@dot_sql_never
@pytest.mark.notyet(
["polars"],
raises=PolarsComputeError,
reason="polars doesn't support selecting from quoted identifiers referencing CTEs",
)
@pytest.mark.notyet(
["druid"],
raises=KeyError,
Expand Down

0 comments on commit 21d9da2

Please sign in to comment.