Skip to content

Commit

Permalink
test(clients): fix more markers
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed Feb 2, 2024
1 parent 1d68786 commit 170518a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
16 changes: 8 additions & 8 deletions ibis/backends/tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def _create_temp_table_with_schema(backend, con, temp_table_name, schema, data=N
],
ids=["no_schema", "schema"],
)
@pytest.mark.notimpl(["dask", "druid"])
@pytest.mark.notimpl(["druid"])
@pytest.mark.notimpl(
["flink"],
reason="Flink backend supports creating only TEMPORARY VIEW for in-memory data.",
Expand Down Expand Up @@ -520,11 +520,6 @@ def test_insert_overwrite_from_dataframe(


@pytest.mark.notimpl(["polars", "pandas"], reason="`insert` method not implemented")
@pytest.mark.notyet(
["risingwave"],
raises=PsycoPg2InternalError,
reason="truncate not supported upstream",
)
def test_insert_no_overwrite_from_expr(
backend, con, employee_empty_temp_table, employee_data_2_temp_table
):
Expand All @@ -549,6 +544,11 @@ def test_insert_no_overwrite_from_expr(
raises=TrinoUserError,
reason="requires a non-memory connector for truncation",
)
@pytest.mark.notyet(
["risingwave"],
raises=PsycoPg2InternalError,
reason="truncate not supported upstream",
)
def test_insert_overwrite_from_expr(
backend, con, employee_data_1_temp_table, employee_data_2_temp_table
):
Expand Down Expand Up @@ -594,7 +594,7 @@ def _emp(a, b, c, d):


@pytest.mark.notimpl(
["polars", "pandas"],
["polars", "dask", "pandas"],
raises=AttributeError,
reason="`insert` method not implemented",
)
Expand All @@ -613,7 +613,7 @@ def test_insert_from_memtable(con, temp_table):


@pytest.mark.notyet(
["bigquery", "oracle", "exasol", "polars", "pandas", "druid"],
["bigquery", "oracle", "dask", "exasol", "polars", "pandas", "druid"],
raises=AttributeError,
reason="doesn't support the common notion of a database",
)
Expand Down
4 changes: 1 addition & 3 deletions ibis/backends/trino/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,7 @@ def load_tpch(self) -> None:
def _tpch_table(self, name: str):
from ibis import _

table = self.connection.table(
self.default_identifier_case_fn(name), schema="ibis_sf1", database="hive"
)
table = self.connection.table(name, schema="ibis_sf1", database="hive")
table = table.mutate(s.across(s.of_type("double"), _.cast("decimal(15, 2)")))
return table

Expand Down

0 comments on commit 170518a

Please sign in to comment.