perf(sql): prevent sqlglot from extensive deepcopying every time we c…

…reate a sqlglot object
ibis-project · Mar 11, 2024 · 005d609 · 005d609
1 parent f33bf51
commit 005d609
Show file tree

Hide file tree

Showing 2 changed files with 126 additions and 71 deletions.
diff --git a/ibis/backends/sql/__init__.py b/ibis/backends/sql/__init__.py
@@ -107,7 +107,7 @@ def _to_sqlglot(
         assert not isinstance(sql, sge.Subquery)
 
         if isinstance(sql, sge.Table):
-            sql = sg.select(STAR).from_(sql)
+            sql = sg.select(STAR, copy=False).from_(sql, copy=False)
 
         assert not isinstance(sql, sge.Subquery)
         return sql
@@ -117,7 +117,7 @@ def compile(
     ):
         """Compile an Ibis expression to a SQL string."""
         query = self._to_sqlglot(expr, limit=limit, params=params, **kwargs)
-        sql = query.sql(dialect=self.dialect, pretty=True)
+        sql = query.sql(dialect=self.dialect, pretty=True, copy=False)
         self._log(sql)
         return sql