Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for App Extension target #13

Closed
skyline75489 opened this issue Nov 21, 2015 · 6 comments
Closed

Add support for App Extension target #13

skyline75489 opened this issue Nov 21, 2015 · 6 comments
Labels
enhancement

Comments

@skyline75489
Copy link

Similar issue as ibireme/YYCategories#3
ibireme added a commit that referenced this issue Nov 21, 2015
@ibireme
Use YY_TARGET_IS_EXTENSION to support App Extension target: #13
5570793
@ibireme
Copy link
Owner

ibireme commented Nov 21, 2015

Added.
You may add YY_TARGET_IS_EXTENSION flag in Build Settings - Preprocessor Macros sections.

@skyline75489
Copy link
Author

AFNetwoking is using NS_EXTENSION_UNAVAILABLE_IOS marco to support Extension target. The PR is here. It allows same code for both app and extension target without defining AF_APP_EXTENSIONS marco. I think maybe this is a better solution.

@Natoto
Copy link

Natoto commented Nov 23, 2015

can't find YYWebImage in pod

@ibireme
Copy link
Owner

ibireme commented Nov 23, 2015

Use pod update --verbose to update your pod list

@ibireme
Copy link
Owner

ibireme commented Nov 23, 2015

I tried NS_EXTENSION_UNAVAILABLE_IOS but it can only be used in compile time for single method.
Inspired by SDWebImage, I use runtime to detect App Extension target: commit 7500348.

@ibireme ibireme mentioned this issue Nov 23, 2015
Closed
@skyline75489
Copy link
Author

Nice approach. I'll close this. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ibireme @Natoto @skyline75489