Add Star Question Type #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
miles-grant-ibigroup
assigned AdrianaCeric and amy-corson-ibigroup and unassigned daniel-heppner-ibigroup and AdrianaCeric
amy-corson-ibigroup
approved these changes
Apr 14, 2023
AdrianaCeric
approved these changes
Apr 17, 2023
| display: none; | ||
| } | ||
|
|
||
| .star { |
There was a problem hiding this comment.
could we also add an outline around the stars
There was a problem hiding this comment.
I tried a few variations of this. Unfortunately the way we render the stars we can't get an outline or shadow on the star itself, only on the box around the star. This could be resolved with clip-path, or totally re-doing how we render the stars...
I do agree though the styling needs some work. Not sure which direction to go... Borders would match the radio button style, maybe editing the svg is the way to go?
You have any other ideas
There was a problem hiding this comment.
Opened #18
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new question type, star. Similar to smiley slider.