Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OTP2 data for bus notifications, improve logging. #265

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Oct 24, 2024

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • [na] The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

More or less a subset of #263.

This PR updates bus notification code to use route and trip data from OTP2 data structures, and improves logging when sending bus notifications.

Copy link
Contributor

@JymDyerIBI JymDyerIBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me.

There are a number of systems with regional agency indicators in the GTFS IDs, I think we're facing that with the MTC pretty soon.

Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but need to clarify: This PR does not include the additional logging in CheckMonitoredTrip should it?

@br648 br648 assigned binh-dam-ibigroup and unassigned br648 and JymDyerIBI Oct 25, 2024
@binh-dam-ibigroup
Copy link
Collaborator Author

Approving, but need to clarify: This PR does not include the additional logging in CheckMonitoredTrip should it?

@br648 This PR covers the logging for the bus notification stuff, not the additional logging for itinerary checks.

@binh-dam-ibigroup binh-dam-ibigroup merged commit a5fe446 into dev Oct 25, 2024
2 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the bus-notifications-otp2 branch October 25, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants