Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Notification String Checks and Add Alert ID #192

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Fix Notification String Checks and Add Alert ID #192

merged 3 commits into from
Nov 13, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Nov 10, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • [na] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • [na] The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR fixes incorrect calls to string.substring and adds a new id field to LocalizedAlerts.

AdrianaCeric
AdrianaCeric approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@AdrianaCeric AdrianaCeric left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on Android 👍 , there are definitely some UI and wording changes we could do in the future

@AdrianaCeric AdrianaCeric removed their assignment Nov 10, 2023
JymDyerIBI
JymDyerIBI approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@JymDyerIBI JymDyerIBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

@binh-dam-ibigroup binh-dam-ibigroup merged commit d81418f into dev Nov 13, 2023
2 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the fix-notif-string-checks branch November 13, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianaCeric AdrianaCeric AdrianaCeric approved these changes

@JymDyerIBI JymDyerIBI JymDyerIBI approved these changes

Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @AdrianaCeric @JymDyerIBI