Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Update json-schema-validator transitive dependency. #187

Merged
merged 1 commit into from
Aug 24, 2023
Merged

chore(deps): Update json-schema-validator transitive dependency. #187

merged 1 commit into from
Aug 24, 2023
+7 −0

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • [na] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • [na] The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR fixes a missing/incorrect transitive dependency in json-schema-validator.jar that now cause build failures.

@br648 br648 assigned miles-grant-ibigroup and unassigned br648 Aug 22, 2023
JymDyerIBI
JymDyerIBI approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@JymDyerIBI JymDyerIBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha!

@binh-dam-ibigroup
Copy link
Collaborator Author

Aha!

Yeah it took some time with @amy-corson-ibigroup to figure this one out!

@binh-dam-ibigroup binh-dam-ibigroup merged commit 9c63b15 into dev Aug 24, 2023
2 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the update-dep-from-json-validator branch August 24, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@br648 br648 br648 approved these changes

@JymDyerIBI JymDyerIBI JymDyerIBI approved these changes

Assignees

@JymDyerIBI JymDyerIBI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@binh-dam-ibigroup @br648 @JymDyerIBI @miles-grant-ibigroup