Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flex spec v2 #599

Merged
merged 21 commits into from
Oct 22, 2024
Merged

Flex spec v2 #599

merged 21 commits into from
Oct 22, 2024

Conversation

br648
Copy link
Contributor

@br648 br648 commented Jul 30, 2024 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Update to include the lastest Flex spec v2.

br648 and others added 19 commits May 15, 2024 11:29
@br648
refactor(Updates to include location groups and location group stops):
6a764ff
@br648
refactor(Remove areas from gtfs test file and unit tests):
777ba4e
@br648
Merge branch 'dev-flex' into feature/DT-423-rename-stop-areas-locatio…
7dc1b5c 
…n-groups
@miles-grant-ibigroup
Merge branch 'dev-flex' into feature/DT-423-rename-stop-areas-locatio…
46cd62c 
…n-groups
@miles-grant-ibigroup
temp: enable docker build
4e17e9c
@br648
refactor(Bumped GTFS-Lib version and fixed failing flex merge test):
38f9fd8
@br648
Merge branch 'feature/DT-423-rename-stop-areas-location-groups' of ht…
f3244cb 
…tps://github.com/ibi-group/datatools-server into feature/DT-423-rename-stop-areas-location-groups
@br648
refactor(pom.xml): Bumped GTFS-lib version
874d08e
@miles-grant-ibigroup
update gtfs.yml to latest spec
41de8f0
@br648
refactor(pom.xml): Bumped GTFS-Lib version
1655d8f
@br648
Merge branch 'feature/DT-423-rename-stop-areas-location-groups' of ht…
c2c14db 
…tps://github.com/ibi-group/datatools-server into feature/DT-423-rename-stop-areas-location-groups
@br648
refactor(pom.xml): Bumped GTFS-Lib version
04a9819
@br648
refactor(Bumped gtfs-lib version):
0c490d6
@br648
Merge branch 'dev-flex' into feature/DT-423-rename-stop-areas-locatio…
dbf3d04 
…n-groups
@br648
refactor(pom.xml): Bumped GTFS-Lib version
a62e3db
@br648
refactor(pom.xml): Included common-lang3 required by GTFS-Lib
45d7036
@br648
refactor(Refined reference table discovery):
40dfe40
@miles-grant-ibigroup
update gtfs-lib
8e2d520
@br648
refactor(pom.xml): Bumped GTFS-lib version
a892b31
JymDyerIBI
JymDyerIBI approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@JymDyerIBI JymDyerIBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good.

@JymDyerIBI JymDyerIBI assigned br648 and unassigned JymDyerIBI Sep 28, 2024
@br648 br648 assigned binh-dam-ibigroup and unassigned br648 Oct 7, 2024
binh-dam-ibigroup
binh-dam-ibigroup approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving subject to the comments indicated.

.github/workflows/build-docker.yml Outdated Show resolved Hide resolved
src/main/resources/gtfs/gtfs.yml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
br648 added 2 commits October 22, 2024 10:27
@br648
refactor(Addressed PR feedback):
2426091
@br648
refactor(pom.xml): Bumped GTFS-lib version
10d924c 
Reinstated methods in gtfs-lib required by MergeFeedJob
@br648 br648 merged commit a7c4121 into dev-flex Oct 22, 2024
2 checks passed
JymDyerIBI
JymDyerIBI reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@JymDyerIBI JymDyerIBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JymDyerIBI JymDyerIBI JymDyerIBI approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@br648 br648

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@br648 @binh-dam-ibigroup @JymDyerIBI @miles-grant-ibigroup