Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support R7A Deployment #597

Merged
merged 2 commits into from
May 22, 2024
Merged

Support R7A Deployment #597

merged 2 commits into from
May 22, 2024

Conversation

miles-grant-ibigroup
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup commented May 21, 2024 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)

Description

Makes some AWS changes that allow us to deploy r7as

daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly what the doctor ordered

josh-willis-arcadis
josh-willis-arcadis approved these changes May 21, 2024
View reviewed changes
Copy link

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exciting!

daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another approval with passing tests!

@miles-grant-ibigroup miles-grant-ibigroup merged commit 8eda625 into dev May 22, 2024
6 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the deploy-r7a branch May 22, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

@josh-willis-arcadis josh-willis-arcadis josh-willis-arcadis approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

@daniel-heppner-ibigroup daniel-heppner-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @daniel-heppner-ibigroup @josh-willis-arcadis