Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI Node Version #587

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Update CI Node Version #587

merged 1 commit into from
Jan 18, 2024

Conversation

miles-grant-ibigroup
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)

Description

Node 18 doesn't work anymore with our CI. We need Node 20. In all places

@clinephi
Copy link

Is Node 20 maybe a bridge too far?

@miles-grant-ibigroup
Copy link
Contributor Author

Is Node 20 maybe a bridge too far?

Thanks for contributing! We welcome PRs.

daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20 is my favorite number so easy approval here.

@miles-grant-ibigroup miles-grant-ibigroup merged commit a36b3a6 into dev Jan 18, 2024
6 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the update-ci-node-2024 branch January 18, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

Assignees

@daniel-heppner-ibigroup daniel-heppner-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miles-grant-ibigroup @clinephi @daniel-heppner-ibigroup @amy-corson-ibigroup