Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade MobilityData Validator to 4.1.0 #571

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Upgrade MobilityData Validator to 4.1.0 #571

merged 6 commits into from
Nov 7, 2023

Conversation

miles-grant-ibigroup
Copy link
Contributor

Upgrades MobilityData validator

Needs ibi-group/datatools-ui#996

This was referenced Oct 20, 2023
Closed
Merged
@miles-grant-ibigroup
Copy link
Contributor Author

Ready for review @philip-cline

philip-cline
philip-cline approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New validator version is working well for me.

br648
br648 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. I ran the MergeFeedJobTest which calls this 20 times. No issues.

@br648 br648 assigned miles-grant-ibigroup and unassigned br648 Nov 7, 2023
@miles-grant-ibigroup miles-grant-ibigroup merged commit 3001771 into dev Nov 7, 2023
6 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the mobility-data-validator-4.1.0 branch November 7, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philip-cline philip-cline philip-cline approved these changes

@br648 br648 br648 approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @br648 @philip-cline